Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] window-size: fix error on loading screen #546

Merged

Conversation

vcapretz
Copy link
Contributor

the window size (height/widhth, x/y) should all be integers

if window tried to load with float numbers it was throwing errors
on the main process.

@RocketChat/DesktopApp

Closes #540

the window size (height/widhth, x/y) should all be integers

if window tried to load with float numbers it was throwing errors
on the main process.
Copy link
Contributor

@alexbrazier alexbrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to do the the Math.floor in the save state function instead? Also, if we always save the state with Math.floor then it shouldn't be necessary to do it again when retrieving the values. But approving anyway as it is ok as it is.

@gdelavald gdelavald merged commit dcaf5a4 into RocketChat:develop Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaScript error occurred in the Main Process - 2.9.0
3 participants