revert: keep macOS native fullscreen when pressing ESC (#3433)

[jeanfbrito]

Reverts #3433 (squash commit 8c6bd9e). The fix did not work after merging to dev; removing it from the 4.17.0 line while the approach is reworked. A follow-up PR restores the change for rework.

Summary by CodeRabbit

• Bug Fixes

  • Simplified Escape-key handling when exiting HTML5 video fullscreen.
  • Removed platform-specific fullscreen interception behavior.

• Documentation

  • Removed the macOS fullscreen Escape QA pack and related test instructions.
  • Updated the QA pack index and removed obsolete pack entries.

• Tests

  • Removed automated and manual coverage for the retired fullscreen Escape behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f8e636f6-ecc7-4181-a85d-aabd0331e27f

📥 Commits

Reviewing files that changed from the base of the PR and between 5b07559 and afa77e6.

⛔ Files ignored due to path filters (1)

• qa/macos-fullscreen-escape/exports/qase-import.csv is excluded by !**/*.csv

📒 Files selected for processing (14)

• qa/README.md
• qa/macos-fullscreen-escape/README.md
• qa/macos-fullscreen-escape/exports/README.md
• qa/macos-fullscreen-escape/flows/01-video-fullscreen-escape.md
• qa/macos-fullscreen-escape/flows/02-plain-escape-keeps-fullscreen.md
• qa/macos-fullscreen-escape/flows/03-escape-and-shortcut-regressions.md
• qa/macos-fullscreen-escape/flows/04-windows-linux-escape-unchanged.md
• qa/macos-fullscreen-escape/results/README.md
• src/ui/main/escapeFullscreenGuard.main.spec.ts
• src/ui/main/escapeFullscreenGuard.ts
• src/ui/main/rootWindow.spec.ts
• src/ui/main/rootWindow.ts
• src/ui/main/serverView/index.spec.ts
• src/ui/main/serverView/index.ts

💤 Files with no reviewable changes (11)

• qa/macos-fullscreen-escape/exports/README.md
• qa/macos-fullscreen-escape/flows/02-plain-escape-keeps-fullscreen.md
• qa/macos-fullscreen-escape/README.md
• qa/macos-fullscreen-escape/results/README.md
• src/ui/main/rootWindow.ts
• qa/macos-fullscreen-escape/flows/01-video-fullscreen-escape.md
• qa/macos-fullscreen-escape/flows/04-windows-linux-escape-unchanged.md
• src/ui/main/escapeFullscreenGuard.ts
• qa/macos-fullscreen-escape/flows/03-escape-and-shortcut-regressions.md
• src/ui/main/rootWindow.spec.ts
• src/ui/main/escapeFullscreenGuard.main.spec.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (3)

• GitHub Check: check (ubuntu-latest)
• GitHub Check: check (windows-latest)
• GitHub Check: check (macos-latest)

🧰 Additional context used

📓 Path-based instructions (7)

Renderer specs must live in a Jest-matched nested path, for example

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• src/ui/main/serverView/index.spec.ts

File naming: camelCase for files, PascalCase for components.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• src/ui/main/serverView/index.spec.ts
• src/ui/main/serverView/index.ts

Renderer specs use `*.spec.ts` / `*.spec.tsx`.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• src/ui/main/serverView/index.spec.ts

Prefer optional chaining and fallbacks for platform-specific APIs:

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• src/ui/main/serverView/index.spec.ts
• src/ui/main/serverView/index.ts

Each QA pack must include a `README.md` with prerequisites, smoke order, evidence format, and a folder map.

📄 CodeRabbit inference engine (qa/AGENTS.md)

Files:

• qa/README.md

QA packs must be usable by both humans and agents, with flows written so a tester with no feature context can follow them and an automation agent can identify the same preconditions, actions, expected results, and evidence.

📄 CodeRabbit inference engine (qa/AGENTS.md)

Files:

• qa/README.md

Avoid subjective descriptors ("smart", "excellent", "dumb").

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• src/ui/main/serverView/index.spec.ts
• src/ui/main/serverView/index.ts
• qa/README.md

---

Walkthrough

The pull request removes macOS fullscreen Escape interception, simplifies server-view Escape handling, deletes related tests, and removes the associated QA pack documentation.

Changes

Fullscreen Escape removal

Layer / File(s)	Summary
Remove fullscreen guard wiring src/ui/main/escapeFullscreenGuard.ts, src/ui/main/rootWindow.ts	The macOS fullscreen Escape guard and the root-window fullscreen-state interception were removed.
Simplify server-view Escape handling src/ui/main/serverView/index.ts	The server view no longer applies platform-specific fullscreen guard logic. Escape is forwarded to the root window outside guest HTML5 fullscreen.
Remove validation and QA materials src/ui/main/rootWindow.spec.ts, src/ui/main/serverView/index.spec.ts, qa/README.md, qa/macos-fullscreen-escape/*	Fullscreen guard tests, related mocks, and the macOS fullscreen Escape QA pack were removed. The QA pack table was reformatted and its removed packs were dropped from the current list.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to afa77

This revert removes the unsuccessful macOS ESC fullscreen behavior change and restores the previous behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested labels: type: bug

Suggested reviewers: scuciatto

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies this change as a revert of the macOS native fullscreen behavior associated with pressing ESC. It matches the pull request objective and deleted implementation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Warning

Errors were encountered while retrieving linked issues.

Errors (1)

• JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}