fix: dedupe Windows notification quick replies (#3467)

src/notifications/main.ts

@@ -48,6 +48,7 @@ const resolveIcon = async (
 const notifications = new Map();
 const notificationTypes = new Map<string, 'voice' | 'text'>();
 const notificationCategories = new Map<string, 'DOWNLOADS' | 'SERVER'>();
+const repliedNotifications = new Set<string>();
 
 const createNotification = async (
   id: string,
@@ -79,6 +80,8 @@ const createNotification = async (
   });
 
   notification.addListener('show', () => {
+    repliedNotifications.delete(id);
+
     dispatchSingle({
       type: NOTIFICATIONS_NOTIFICATION_SHOWN,
       payload: { id },
@@ -126,6 +129,11 @@ const createNotification = async (
   });
 
   notification.addListener('reply', (_event, reply) => {
+    if (repliedNotifications.has(id)) {
+      return;
+    }
+    repliedNotifications.add(id);
+
     dispatchSingle({
       type: NOTIFICATIONS_NOTIFICATION_REPLIED,
       payload: { id, reply },

src/notifications/main/setup.main.spec.ts

@@ -121,6 +121,11 @@ describe('notifications/main setupNotifications', () => {
     });
   };
 
+  const repliedCalls = () =>
+    dispatchSingle.mock.calls.filter(
+      ([action]) => action.type === NOTIFICATIONS_NOTIFICATION_REPLIED
+    );
+
   it('creates a notification and wires show/click/close/reply/action', async () => {
     await create({
       title: 'Hello',
@@ -181,6 +186,35 @@ describe('notifications/main setupNotifications', () => {
     );
   });
 
+  it('dispatches a duplicated reply event exactly once', async () => {
+    await create({ title: 'Hello', tag: 'reply-once' });
+
+    const notification = notificationInstances[0];
+    notification.emit('reply', {}, 'hi there');
+    notification.emit('reply', {}, 'hi there');
+
+    expect(repliedCalls()).toHaveLength(1);
+    expect(repliedCalls()[0][0].payload).toEqual({
+      id: 'reply-once',
+      reply: 'hi there',
+    });
+  });
+
+  it('accepts another reply after the notification is shown again', async () => {
+    await create({ title: 'Hello', tag: 'reply-again' });
+
+    const notification = notificationInstances[0];
+    notification.emit('reply', {}, 'first reply');
+    notification.emit('show');
+    notification.emit('reply', {}, 'second reply');
+
+    expect(repliedCalls()).toHaveLength(2);
+    expect(repliedCalls()[1][0].payload).toEqual({
+      id: 'reply-again',
+      reply: 'second reply',
+    });
+  });
+
   it('draws attention for voice notifications', async () => {
     await create({
       title: 'Call',