-
Notifications
You must be signed in to change notification settings - Fork 833
fix: keep macOS native fullscreen when pressing ESC #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6398b5d
fix: keep macOS native fullscreen when pressing ESC
scuciatto 388cf21
test: cover the macOS Escape fullscreen guard
scuciatto 5073945
fix: harden the Escape fullscreen guard replay bookkeeping
jeanfbrito 0ad8b84
ci: trigger pull request artifact build
jeanfbrito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # macOS Fullscreen Escape QA Pack | ||
|
|
||
| This folder contains manual and agent-readable QA flows for the macOS native | ||
| fullscreen behavior of the Escape key. It covers the case where the app window is | ||
| in native fullscreen and the Escape key must not drop the window out of | ||
| fullscreen, whether or not a video is playing in HTML5 fullscreen. | ||
|
|
||
| This behavior cannot be proven by the Jest suite. The bug lives in how macOS | ||
| AppKit reacts to a real key event coming from the operating system, and any test | ||
| generated key event is synthetic and never reaches AppKit. Automated tests only | ||
| protect the desktop-side wiring, so these flows are the coverage for the OS half | ||
| and must be run on real macOS hardware. | ||
|
|
||
| The flows are intentionally written for testers without implementation context. | ||
|
|
||
| ## Quick Start | ||
|
|
||
| From the repo root: | ||
|
|
||
| ```sh | ||
| node qa/scripts/validate-flows.mjs qa/macos-fullscreen-escape | ||
| node qa/scripts/export-qase-csv.mjs qa/macos-fullscreen-escape | ||
| ``` | ||
|
|
||
| ## Smoke Order | ||
|
|
||
| 1. Run `flows/01-video-fullscreen-escape.md`. | ||
| 2. Run `flows/02-plain-escape-keeps-fullscreen.md`. | ||
| 3. Run `flows/03-escape-and-shortcut-regressions.md`. | ||
| 4. Run `flows/04-windows-linux-escape-unchanged.md` on Windows and Linux. | ||
|
|
||
| ## Flow Result Format | ||
|
|
||
| ```text | ||
| Flow ID: | ||
| Platform: | ||
| Build: | ||
| Review range: | ||
| Coverage: Full requested range | Partial surface review | ||
| Result: Pass | Fail | Blocked | ||
| Finding status: confirmed | suspected | blocked | none | ||
| Evidence: | ||
| Notes: | ||
| ``` | ||
|
|
||
| ## Folder Map | ||
|
|
||
| | Path | Purpose | | ||
| | ---------- | ----------------------------------------------------------------- | | ||
| | `flows/` | Structured QA flows | | ||
| | `exports/` | Generated Qase CSV exports | | ||
| | `results/` | Optional local evidence area; do not commit run-specific evidence | | ||
|
|
||
| ## Source Of Truth | ||
|
|
||
| When updating this pack, derive expected behavior from: | ||
|
|
||
| - `src/ui/main/escapeFullscreenGuard.ts` | ||
| - `src/ui/main/escapeFullscreenGuard.main.spec.ts` | ||
| - `src/ui/main/serverView/index.ts` (`before-input-event` handling for guest views) | ||
| - `src/ui/main/rootWindow.ts` (`before-input-event` handling for the app chrome) | ||
| - `src/ui/main/menuBar.ts` (macOS `Full screen` item, `Control+Command+F`) | ||
| - `src/ui/components/TabBar/styles.tsx` (`TrafficLightSpacer` collapses in fullscreen) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Qase Exports | ||
|
|
||
| This directory is for generated Qase import files. | ||
|
|
||
| Run: | ||
|
|
||
| ```sh | ||
| node qa/scripts/export-qase-csv.mjs qa/macos-fullscreen-escape | ||
| ``` | ||
|
|
||
| The script writes `qase-import.csv`. Import it in Qase with source type | ||
| `Qase.io`. | ||
|
|
||
| Do not hand-edit generated CSV files. Edit the Markdown flows, validate them, | ||
| and export again. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add explicit prerequisites to the pack README.
List the required setup for an installed branch build, a logged-in workspace, a local video file, and network access for the embedded-player case. Do not require testers to infer these prerequisites from individual flows.
As per coding guidelines, each QA pack
README.mdmust include prerequisites, smoke order, evidence format, and a folder map.🤖 Prompt for AI Agents
Source: Coding guidelines