Add telephony clipboard dial shortcut

[jeanfbrito]

Summary

• add a configurable global telephony shortcut for dialing clipboard phone numbers
• add Desktop Settings controls for shortcut and telephony workspace selection
• share the telephony dialpad opener between deep links and shortcut handling
• harden shortcut registration, reserved accelerators, clipboard size handling, and empty dialpad behavior
• stabilize shortcut notification click handling

Validation

• yarn .:lint:tsc
• yarn eslint on touched TS/TSX files
• git diff --check

Note: local Electron Jest runner was previously crashing on this machine while validating the follow-up; static validation passed.

Summary by CodeRabbit

• New Features

  • Added global keyboard shortcut configuration for initiating telephony calls.
  • Users can capture, save, and manage shortcut accelerators in Settings with validation and error feedback.
  • Integrated clipboard reading with global shortcut trigger for automatic phone number extraction.

• Documentation

  • Updated telephony server setting description to clarify support for global shortcuts and tel:/callto: link handling.

[coderabbitai]

Walkthrough

This PR introduces a "Telephony Global Shortcut" feature for Rocket.Chat Electron. Users can configure a global keyboard accelerator that, when pressed, reads clipboard text, extracts a phone number, and opens a dialpad to make calls. The feature includes main-process shortcut registration, Redux state management with persistence, a refactoring of existing deep-link telephony logic, and a React settings UI component.

Changes

Telephony Global Shortcut

Layer / File(s)	Summary
Telephony Link Types and Redux Actions src/telephony/common.ts, src/telephony/actions.ts	Defines TelephonyLink type and Redux action constants/payload types for global shortcut configuration and registration status updates.
Link Parsing and Accelerator Validation src/telephony/links.ts, src/telephony/shortcuts.ts	Implements parseTelephonyLink for parsing tel: and callto: URIs, normalizeTelephonyShortcutAccelerator for keyboard input validation, and isReservedTelephonyShortcutAccelerator to check against reserved system shortcuts.
Deep Links Refactoring src/deepLinks/main.ts, src/deepLinks/main.spec.ts	Removes inline telephony implementation and delegates to dedicated modules via openTelephonyDialpad and parseTelephonyLink imports; re-exports telephony functions for external callers.
Dialpad Opening Orchestration src/telephony/dialpad.ts	Implements openTelephonyDialpad: polls for Electron WebContents, selects server (single, preferred, or modal-driven), and sends telephony/call-requested message with phone number and raw URI.
Global Shortcut Main Process src/telephony/main.ts, src/telephony/main.spec.ts	Implements Electron main-process shortcut handler: normalizes config, registers/unregisters global accelerator, reads/validates clipboard text, debounces repeated triggers, handles registration failures with notifications, and watches config changes. Includes tests for registration flow, clipboard handling, accelerator validation, and reducer hydration.
Redux State, Persistence, and Selectors src/app/PersistableValues.ts, src/app/PersistableValues.spec.ts, src/telephony/reducers.ts, src/store/rootReducer.ts, src/app/selectors.ts	Adds Redux state slices for shortcut config and registration status; implements reducers with APP_SETTINGS_LOADED hydration; adds 4.14.0 persistence migration backfilling defaults; wires into rootReducer and exposes selector for persisted config.
Application Startup Integration src/main.ts, src/main.spec.ts	Calls setupTelephonyGlobalShortcut() during app boot sequence right after deep-link setup; adds mock for test coverage.
Telephony Global Shortcut Settings Component src/ui/components/SettingsView/features/TelephonyGlobalShortcut.tsx, src/ui/components/SettingsView/features/TelephonyGlobalShortcut.spec.tsx, src/ui/components/SettingsView/GeneralTab.tsx	React component for keyboard accelerator configuration: supports manual input and on-focus key capture, validates against reserved accelerators, dispatches config updates, displays registration errors, and shows confirmation when registered. Includes extensive component tests covering save, capture, clear, validation, and error feedback scenarios.
Localization and IPC Renderer Tests src/i18n/en.i18n.json, src/telephony/renderer/preload.spec.ts	Adds i18n strings for shortcut settings UI and test coverage for renderer IPC callback with empty telephony payloads.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant GlobalShortcut as Electron globalShortcut
  participant Clipboard as Electron clipboard
  participant Dialpad as openTelephonyDialpad
  participant Window as Root Window
  User->>GlobalShortcut: Press registered accelerator
  GlobalShortcut->>Clipboard: Read clipboard text
  Clipboard-->>GlobalShortcut: Phone/link text
  GlobalShortcut->>Dialpad: parseTelephonyLink, openTelephonyDialpad
  Dialpad->>Window: Focus window, send telephony/call-requested

Loading

sequenceDiagram
  participant User
  participant Component as TelephonyGlobalShortcut
  participant Redux
  User->>Component: Type or capture accelerator
  Component->>Component: Draft local state
  User->>Component: Click Save
  Component->>Redux: Dispatch TELEPHONY_GLOBAL_SHORTCUT_CONFIG_SET
  Redux->>Component: Updated config/registration status
  Component->>User: Render updated UI with validation/error feedback

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Suggested labels

type: feature

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main feature: adding a global telephony shortcut that dials phone numbers from the clipboard. It is concise, specific, and clearly summarizes the primary change in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

src/app/PersistableValues.spec.ts (1)

4-16: ⚡ Quick win

Consider adding a test case for missing telephonyPreferredServer.

The migration correctly handles the case where telephonyPreferredServer is missing (defaulting to null), but this scenario isn't tested. Adding a test would improve coverage.

📝 Suggested additional test

  it('defaults telephonyPreferredServer to null when missing', () => {
    const before = {} as unknown as Parameters<(typeof migrations)['>=4.14.0']>[0];

    expect(migrations['>=4.14.0'](before)).toEqual({
      telephonyPreferredServer: null,
      telephonyGlobalShortcutConfig: {
        enabled: false,
        accelerator: null,
      },
    });
  });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/PersistableValues.spec.ts` around lines 4 - 16, Add a new unit test
in PersistableValues.spec.ts that calls migrations['>=4.14.0'] with an empty
input object to assert the migration sets telephonyPreferredServer to null and
still adds telephonyGlobalShortcutConfig with enabled: false and accelerator:
null; specifically, create a test similar to the suggested snippet that
constructs before = {} as Parameters<(typeof migrations)['>=4.14.0']>[0] and
expects the returned object to equal { telephonyPreferredServer: null,
telephonyGlobalShortcutConfig: { enabled: false, accelerator: null } } so the
missing-server case is covered.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/app/PersistableValues.spec.ts`:
- Around line 5-7: The const declaration for before contains unnecessary
wrapping parentheses around the object literal which breaks Prettier; edit the
declaration of before in PersistableValues.spec.ts (the variable named before
used with the cast to Parameters<(typeof migrations)['>=4.14.0']>[0]) to remove
the extra surrounding parentheses so the expression is written as an object
literal followed by the double cast (e.g. object as unknown as
Parameters<...>[0]), then run Prettier to confirm formatting.

In `@src/telephony/reducers.ts`:
- Around line 48-50: Prettier flagged the formatting around the call to
normalizeTelephonyShortcutAccelerator; reformat the statement so it complies
with project Prettier rules (for example collapse to a single line: const
accelerator = normalizeTelephonyShortcutAccelerator(config.accelerator);) and
then run the project's Prettier/formatting step to ensure consistent style for
the normalizeTelephonyShortcutAccelerator and config.accelerator usage.

---

Nitpick comments:
In `@src/app/PersistableValues.spec.ts`:
- Around line 4-16: Add a new unit test in PersistableValues.spec.ts that calls
migrations['>=4.14.0'] with an empty input object to assert the migration sets
telephonyPreferredServer to null and still adds telephonyGlobalShortcutConfig
with enabled: false and accelerator: null; specifically, create a test similar
to the suggested snippet that constructs before = {} as Parameters<(typeof
migrations)['>=4.14.0']>[0] and expects the returned object to equal {
telephonyPreferredServer: null, telephonyGlobalShortcutConfig: { enabled: false,
accelerator: null } } so the missing-server case is covered.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5dedff6e-cf6b-4a36-84a2-78df6d17d6b8

📥 Commits

Reviewing files that changed from the base of the PR and between 3c2ab23 and 77edf36.

📒 Files selected for processing (21)

• src/app/PersistableValues.spec.ts
• src/app/PersistableValues.ts
• src/app/selectors.ts
• src/deepLinks/main.spec.ts
• src/deepLinks/main.ts
• src/i18n/en.i18n.json
• src/main.spec.ts
• src/main.ts
• src/store/rootReducer.ts
• src/telephony/actions.ts
• src/telephony/common.ts
• src/telephony/dialpad.ts
• src/telephony/links.ts
• src/telephony/main.spec.ts
• src/telephony/main.ts
• src/telephony/reducers.ts
• src/telephony/renderer/preload.spec.ts
• src/telephony/shortcuts.ts
• src/ui/components/SettingsView/GeneralTab.tsx
• src/ui/components/SettingsView/features/TelephonyGlobalShortcut.spec.tsx
• src/ui/components/SettingsView/features/TelephonyGlobalShortcut.tsx

📜 Review details

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Use TypeScript for all new code in this codebase unless explicitly told otherwise
Use Fuselage components from @rocket.chat/fuselage for all UI work — only create custom components when Fuselage doesn't provide the needed functionality
Check Theme.d.ts for valid color tokens when working with Fuselage components
Use optional chaining with fallbacks for platform-specific APIs instead of mocks (e.g., process.getuid?.() ?? 1000) to ensure code works across all platforms without requiring mocks
TypeScript code must use strict mode
Use React functional components with hooks instead of class components
Redux actions must follow the FSA (Flux Standard Action) pattern
Use camelCase for file naming
Use PascalCase for component file names (React components)
Write self-documenting code through clear naming — avoid unnecessary comments

Files:

• src/ui/components/SettingsView/GeneralTab.tsx
• src/deepLinks/main.spec.ts
• src/telephony/renderer/preload.spec.ts
• src/telephony/reducers.ts
• src/main.spec.ts
• src/telephony/links.ts
• src/telephony/shortcuts.ts
• src/main.ts
• src/ui/components/SettingsView/features/TelephonyGlobalShortcut.tsx
• src/app/selectors.ts
• src/telephony/common.ts
• src/app/PersistableValues.spec.ts
• src/telephony/dialpad.ts
• src/telephony/actions.ts
• src/telephony/main.spec.ts
• src/telephony/main.ts
• src/store/rootReducer.ts
• src/app/PersistableValues.ts
• src/ui/components/SettingsView/features/TelephonyGlobalShortcut.spec.tsx
• src/deepLinks/main.ts

**/*.spec.ts

📄 CodeRabbit inference engine (CLAUDE.md)

Use *.spec.ts file naming convention for Renderer process tests

Files:

• src/deepLinks/main.spec.ts
• src/telephony/renderer/preload.spec.ts
• src/main.spec.ts
• src/app/PersistableValues.spec.ts
• src/telephony/main.spec.ts

**/*.{spec,main.spec}.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{spec,main.spec}.ts: Tests must run and pass on Windows, macOS, and Linux CI environments — always verify cross-platform compatibility
Only mock Linux-only APIs (process.getuid(), process.getgid(), process.geteuid(), process.getegid()) when defensive coding with optional chaining isn't possible

Files:

• src/deepLinks/main.spec.ts
• src/telephony/renderer/preload.spec.ts
• src/main.spec.ts
• src/app/PersistableValues.spec.ts
• src/telephony/main.spec.ts

🪛 ESLint

src/telephony/reducers.ts

[error] 48-50: Replace ⏎····config.accelerator⏎·· with config.accelerator

(prettier/prettier)

src/app/PersistableValues.spec.ts

[error] 5-5: Delete (

(prettier/prettier)

---

[error] 7-7: Delete )

(prettier/prettier)

🔇 Additional comments (27)

src/telephony/common.ts (1)

1-4: LGTM!

src/telephony/actions.ts (1)

2-5: LGTM!

Also applies to: 7-16, 20-21

src/telephony/links.ts (1)

1-38: LGTM!

src/telephony/shortcuts.ts (1)

1-40: LGTM!

src/deepLinks/main.ts (1)

10-13: LGTM!

Also applies to: 21-24, 208-208

src/deepLinks/main.spec.ts (1)

191-205: LGTM!

src/app/PersistableValues.ts (1)

110-219: LGTM!

src/telephony/reducers.ts (1)

28-107: LGTM!

src/store/rootReducer.ts (1)

21-25: LGTM!

Also applies to: 127-128

src/app/selectors.ts (1)

88-90: LGTM!

src/main.ts (1)

47-47: LGTM!

Also applies to: 124-124

src/main.spec.ts (1)

118-120: LGTM!

src/ui/components/SettingsView/features/TelephonyGlobalShortcut.tsx (2)

1-228: LGTM!

---

1-248: LGTM!

src/ui/components/SettingsView/GeneralTab.tsx (1)

15-15: LGTM!

Also applies to: 40-40

src/i18n/en.i18n.json (1)

302-302: LGTM!

Also applies to: 305-314

src/telephony/renderer/preload.spec.ts (1)

108-122: LGTM!

src/telephony/dialpad.ts (3)

17-40: LGTM!

---

42-100: LGTM!

---

102-132: LGTM!

src/telephony/main.ts (6)

38-51: LGTM!

---

53-86: LGTM!

---

88-117: LGTM!

---

119-151: LGTM!

---

153-225: LGTM!

---

227-252: LGTM!

src/telephony/main.spec.ts (1)

1-525: LGTM!

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove extra parentheses to fix prettier formatting.

The static analysis tool correctly identified unnecessary parentheses that violate the project's formatting rules.

🔧 Proposed fix

-    const before = ({
+    const before = {
       telephonyPreferredServer: 'https://chat.example.com',
-    } as unknown) as Parameters<(typeof migrations)['>=4.14.0']>[0];
+    } as unknown as Parameters<(typeof migrations)['>=4.14.0']>[0];

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const before = ({
	telephonyPreferredServer: 'https://chat.example.com',
	} as unknown) as Parameters<(typeof migrations)['>=4.14.0']>[0];
	const before = {
	telephonyPreferredServer: 'https://chat.example.com',
	} as unknown as Parameters<(typeof migrations)['>=4.14.0']>[0];

🧰 Tools

🪛 ESLint

[error] 5-5: Delete (

(prettier/prettier)

---

[error] 7-7: Delete )

(prettier/prettier)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/PersistableValues.spec.ts` around lines 5 - 7, The const declaration
for before contains unnecessary wrapping parentheses around the object literal
which breaks Prettier; edit the declaration of before in
PersistableValues.spec.ts (the variable named before used with the cast to
Parameters<(typeof migrations)['>=4.14.0']>[0]) to remove the extra surrounding
parentheses so the expression is written as an object literal followed by the
double cast (e.g. object as unknown as Parameters<...>[0]), then run Prettier to
confirm formatting.

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix prettier formatting.

The static analysis tool identified a formatting issue that should be addressed.

🔧 Proposed fix

-  const accelerator = normalizeTelephonyShortcutAccelerator(
-    config.accelerator
-  );
+  const accelerator = normalizeTelephonyShortcutAccelerator(config.accelerator);

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	const accelerator = normalizeTelephonyShortcutAccelerator(
	config.accelerator
	);
	const accelerator = normalizeTelephonyShortcutAccelerator(config.accelerator);

🧰 Tools

🪛 ESLint

[error] 48-50: Replace ⏎····config.accelerator⏎·· with config.accelerator

(prettier/prettier)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/telephony/reducers.ts` around lines 48 - 50, Prettier flagged the
formatting around the call to normalizeTelephonyShortcutAccelerator; reformat
the statement so it complies with project Prettier rules (for example collapse
to a single line: const accelerator =
normalizeTelephonyShortcutAccelerator(config.accelerator);) and then run the
project's Prettier/formatting step to ensure consistent style for the
normalizeTelephonyShortcutAccelerator and config.accelerator usage.