Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refresh supported versions whenever the app goes online #2820

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

tassoevan
Copy link
Collaborator

@tassoevan tassoevan commented Jan 23, 2024

It forces refetching the supported server versions whenever the computer goes online. Additionally, it centralizes all internal URLs into a single module for easy maintainance.

@tassoevan tassoevan marked this pull request as ready for review January 23, 2024 16:43
@tassoevan tassoevan requested a review from a team January 23, 2024 16:43
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice refactor also

@ggazzo ggazzo merged commit 5cea4d8 into master Jan 30, 2024
6 checks passed
@ggazzo ggazzo deleted the refactor/refresh-supported-versions branch January 30, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants