Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sidebar color #2655

Merged
merged 5 commits into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/servers/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export type Server = {
style?: {
background: string | null;
color: string | null;
border: string | null;
};
lastPath?: string;
failed?: boolean;
Expand Down
3 changes: 2 additions & 1 deletion src/servers/preload/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
getInternalVideoChatWindowEnabled,
openInternalVideoChatWindow,
} from './internalVideoChatWindow';
import { setBackground } from './sidebar';
import { setBackground, setServerVersionToSidebar } from './sidebar';
import { setTitle } from './title';
import { setUrlResolver } from './urls';
import { setUserLoggedIn } from './userLoggedIn';
Expand Down Expand Up @@ -62,6 +62,7 @@ export const RocketChatDesktop: RocketChatDesktopAPI = {
setServerInfo: (_serverInfo) => {
serverInfo = _serverInfo;
cb(_serverInfo);
setServerVersionToSidebar(_serverInfo.version);
},
setUrlResolver,
setBadge,
Expand Down
57 changes: 51 additions & 6 deletions src/servers/preload/sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,30 @@ import { getServerUrl, getAbsoluteUrl } from './urls';
let timer: ReturnType<typeof setTimeout>;
let prevBackground: string;
let prevColor: string;
let prevBorder: string;
let serverVersion: string;

function versionIsGreaterOrEqualsTo(
version1: string,
version2: string
): boolean {
const v1 = version1.match(/\d+/g)?.map(Number) || [];
const v2 = version2.match(/\d+/g)?.map(Number) || [];

for (let i = 0; i < 3; i++) {
const n1 = v1[i] || 0;
const n2 = v2[i] || 0;

if (n1 > n2) {
return true;
}
if (n1 < n2) {
return false;
}
}

return true;
}

const pollSidebarStyle = (
referenceElement: Element,
Expand All @@ -14,35 +38,56 @@ const pollSidebarStyle = (
clearTimeout(timer);

document.body.append(referenceElement);
const { background, color } = window.getComputedStyle(referenceElement);
const { background, color, border } =
window.getComputedStyle(referenceElement);

referenceElement.remove();

if (prevBackground !== background || prevColor !== color) {
const newBgg = prevBackground !== background ? background : prevBackground;
const newColor = prevColor !== color ? color : prevColor;
const newBorder = prevBorder !== border ? border : prevBorder;

if (
prevBackground !== background ||
prevColor !== color ||
newBorder !== border
) {
emit({
background,
color,
background: newBgg,
color: newColor,
border: newBorder,
});
prevBackground = background;
prevColor = color;
prevBorder = border;
}

timer = setTimeout(() => pollSidebarStyle(referenceElement, emit), 1000);
timer = setTimeout(() => pollSidebarStyle(referenceElement, emit), 5000);
};

let element: HTMLElement;

const getElement = (): HTMLElement => {
if (!element) {
element = document.createElement('div');
element.classList.add('sidebar');
element.style.backgroundColor = 'var(--sidebar-background)';
element.style.color = 'var(--sidebar-item-text-color)';
element.style.display = 'none';
if (versionIsGreaterOrEqualsTo(serverVersion, '6.3.0')) {
element.classList.add('rcx-sidebar--main');
element.style.border = '1px solid var(--sidebar-border-color)';
} else {
element.classList.add('sidebar');
}
}

return element;
};

export const setServerVersionToSidebar = (version: string): void => {
serverVersion = version;
};

export const setBackground = (imageUrl: string): void => {
const element = getElement();

Expand Down
6 changes: 5 additions & 1 deletion src/ui/components/SideBar/styles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ type WrapperProps = {
sideBarStyle: {
background?: string;
color?: string;
border?: string;
};
isVisible: boolean;
};
Expand All @@ -32,6 +33,10 @@ export const Wrapper = styled.div<WrapperProps>`
${({ sideBarStyle: { color } }) =>
css`
color: ${color ?? '#ffffff'};
`}
${({ sideBarStyle: { border } }) =>
css`
border: ${border ?? 'none'};
`}
${({ isVisible }) =>
!isVisible &&
Expand All @@ -50,7 +55,6 @@ export const Content = styled.div<ContentProps>`
flex-direction: column;
flex: 1 1 0;
padding-top: 10px;
background-color: rgba(0, 0, 0, 0.1);
align-items: stretch;

${({ withWindowButtons }) =>
Expand Down