fix: Video calls open again on Electron window #2495
Conversation
|
The opposite is happening ... VC oppens in safari now while it was opening in electron window until the update ... we tried both positions of the "open video chat using application window" switch (we're using jitsi) |
|
@chrisi51 |
|
thx for checking ... were on an older version due to UCS: |
|
@chrisi51 your server is public? Could I connect to it to test? You can reach me on open.rocket.chat if positive. |
|
no its private :( and also not very easy to bring it public for testing right now :) |
|
no problem, I'm spinning up some servers to test it |
|
@chrisi51 already fixed it, will make a release today yet. The problem was the way jitsi domain string comes on some servers. |
|
ok, i will have a check on that later |
|
@jeanfbrito yep its working - thx! |
|
@jeanfbrito not working for me here using 3.8.11 + Jitsi + Rocketchat 5.1.3 -> still opening in (default) browser |
|
This will work only on versions below 4.8.2 and above 5.2.
The Rocket.Chat 5.2 will be released soon and then it will start working on
it. We needed to change things because of the video conference on version 5
and it will be ready on this week release.
Em ter., 27 de set. de 2022 08:44, amsnek ***@***.***>
escreveu:
… @jeanfbrito <https://github.com/jeanfbrito> hmm not working for me
either, using 3.8.11 + Jitsi + Rocketchat 5.1.3 -> still opening in
(default) browser
also cleared all %appdata% etc -> but no effect
—
Reply to this email directly, view it on GitHub
<#2495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI7PCQGJZAPLAD5G2TDM3DWALMYDANCNFSM6AAAAAAQDM5FCM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ah this makes sense, i wasnt sure if the 5.2 wasnt a typo since there is no 5.2 yet. Thanks, that is good to know. |
|
Yeah I released the desktop before the server version to be ready when the
server updates.
I needed to change code inside the server this time, this is why this time
we need a server release. After that it will be working with any video
conference provider. Before was just jitsi and BBB.
Em ter., 27 de set. de 2022 09:16, amsnek ***@***.***>
escreveu:
… This will work only on versions below 4.8.2 and above 5.2.
Ah this makes sense, i wasnt sure if the 5.2 wasnt a typo since there is
no 5.2 yet. Thanks, that is good to know.
—
Reply to this email directly, view it on GitHub
<#2495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI7PCUL4KJEAFVXGOS6XG3WALQSNANCNFSM6AAAAAAQDM5FCM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closes #2480