Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notification Types for download cancelled & completed added. #2485

Merged

Conversation

henit-chobisa
Copy link
Contributor

Closed #2484

Issue in brief :

After starting a new download when we cancel the download, we get a notification that the download has finished, which can be misleading.

Suggested Fixes / Changes:

When the download item triggers the done event, it can have only 3 states completed, cancelled, interrupted.

Hence, the possible fix would be to show a different notification when the download is not completed i.e. the download is in the above remaining two states.

Demo of the above suggestion :

downloadNotSolution2GIF

@jeanfbrito
Copy link
Collaborator

Do you think that we need a download cancelled notification?
Maybe a failed one, but cancelled I think that the user is already aware, right?

@jeanfbrito
Copy link
Collaborator

Oh now I got it. If you cancel it shows the complete notification.a
You can see to add a failed notification on the future.

@jeanfbrito jeanfbrito merged commit afa6454 into RocketChat:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong notification after download is cancelled
2 participants