fix: Notification Types for download cancelled & completed added. #2485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #2484
Issue in brief :
After starting a new download when we cancel the download, we get a notification that the download has finished, which can be misleading.
Suggested Fixes / Changes:
When the download item triggers the done event, it can have only 3 states
completed
,cancelled
,interrupted
.Hence, the possible fix would be to show a different notification when the download is not completed i.e. the download is in the above remaining two states.
Demo of the above suggestion :