Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Stop setting build id links for rpm packages #2421

Conversation

stopal
Copy link
Contributor

@stopal stopal commented May 27, 2022

Closes #2303

rpmbuild generates build_id links by default, which are debugging symbols for binaries included in a package. This causes problems between Electron applications which share the same Electron binary, as the debugging symbols conflict with each other.

By disabling the generation of these links i can verify that i can install the resulting rpm package again along with other Electron applications.

See also :

* rpmbuild generates build_id links by default, which are debugging symbols for binaries included in a package. This causes problems between Electron applications which share the same Electron binary, as the debugging symbols conflict with each other.
* See also : https://github.com/rpm-software-management/rpm/blob/rpm-4.18.x/macros.in#L470
@CLAassistant
Copy link

CLAassistant commented May 27, 2022

CLA assistant check
All committers have signed the CLA.

@jeanfbrito
Copy link
Collaborator

Hey @stopal, thank you for your contribuition. Did you tested building and installed using the RPM package?
What I need to test it if is working?

@stopal
Copy link
Contributor Author

stopal commented May 29, 2022

Hi @jeanfbrito,
yeah i ran the release npm task to build all packages and installed the resulting RPM package.
I can verify that it doesnt clash with other electron application anymore.

I am running Fedora 36 btw.

@jeanfbrito jeanfbrito merged commit 80daf9f into RocketChat:master May 30, 2022
@stopal stopal deleted the stop_creating_build_id_links_for_rpm_packages branch May 31, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RocketChat RPM prevents update of other electron based apps ( /usr/lib/.build-id/* file conflicts)
3 participants