fix: Run menu bar event listeners asynchronously (#2254)

RocketChat · Dec 14, 2021 · d99352a · d99352a
1 parent 8920d85
commit d99352a
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/ui/main/menuBar.ts b/src/ui/main/menuBar.ts
@@ -493,7 +493,13 @@ const createWindowMenu = createSelector(
         label: t('menus.downloads'),
         checked: currentView === 'downloads',
         accelerator: 'CommandOrControl+D',
-        click: () => {
+        click: async () => {
+          const browserWindow = await getRootWindow();
+
+          if (!browserWindow.isVisible()) {
+            browserWindow.showInactive();
+          }
+          browserWindow.focus();
           dispatch({ type: SIDE_BAR_DOWNLOADS_BUTTON_CLICKED });
         },
       },
@@ -502,7 +508,13 @@ const createWindowMenu = createSelector(
         label: t('menus.settings'),
         checked: currentView === 'settings',
         accelerator: 'CommandOrControl+I',
-        click: () => {
+        click: async () => {
+          const browserWindow = await getRootWindow();
+
+          if (!browserWindow.isVisible()) {
+            browserWindow.showInactive();
+          }
+          browserWindow.focus();
           dispatch({ type: SIDE_BAR_SETTINGS_BUTTON_CLICKED });
         },
       },