IPreRoomUserLeave and IPostRoomUserLeave event interfaces

[lucassartor]

What? ⛵

Added: New event interfaces for pre/post user leaving a room, IPreRoomUserLeave and IPostRoomUserLeave

Why? 🤔

Links 🌎

Task

PS 👀

[codecov]

Codecov Report

Merging #387 (bfe5665) into alpha (ac2af0c) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            alpha     #387      +/-   ##
==========================================
- Coverage   49.59%   49.28%   -0.32%     
==========================================
  Files         102      102              
  Lines        3176     3196      +20     
  Branches      468      472       +4     
==========================================
  Hits         1575     1575              
- Misses       1601     1621      +20     

Impacted Files	Coverage Δ
src/server/managers/AppListenerManager.ts	6.52% <0.00%> (-0.30%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2af0c...bfe5665. Read the comment docs.

[d-gubert]

Hey @lucassartor, can you share the app you've made to test the functionality? Thanks 🤗

[d-gubert]

Also, regarding the  IRoomUserLeaveContext interface, is it possible to add the user who kicked the leavingUser when that is the case? I'm not sure that is available on the Rocket.Chat side, so maybe not possible at all

[lucassartor]

Hey @lucassartor, can you share the app you've made to test the functionality? Thanks 🤗

Sure! I'll link the compiled app that I've made to test it.
user-leave_0.0.1.zip

[lucassartor]

Also, regarding the  IRoomUserLeaveContext interface, is it possible to add the user who kicked the leavingUser when that is the case? I'm not sure that is available on the Rocket.Chat side, so maybe not possible at all

I've tried to create a kicker in the IRoomUserLeaveContext interface but I was unable to get that information from the Rocket.Chat side.
I think that's currently not possible, but I'm not 100% sure, maybe I got it wrong on the implementation.

[d-gubert]

@RocketChat/backend halp! can some of you confirm the information above is not available?

[sampaiodiego]

we have beforeLeaveRoom and afterLeaveRoom callbacks:
https://github.com/RocketChat/Rocket.Chat/blob/f7700514e50287179b4a93f4eb76747dce83ac47/app/lib/server/functions/removeUserFromRoom.js#L10

is that what you guys are missing?

[d-gubert]

@sampaiodiego we're wondering if it is possible to get the user who kicked another user from a room. For instance, if user A kicks user B from the room, the event will trigger with the room and user B in the context - is there a way to tell that user A was the one who made that action, so we can add this to the context as well?

[sampaiodiego]

that's little messy 🙈 for event afterRemoveFromRoom we have that information.. but not sure if it triggers on all events needed.

[sampaiodiego]

if that is not enough I'd say we should start using a new structure built on top of services to expand that. we can discuss how that should look like.

[d-gubert]

Ok, we'll move on with this implementation now, then. After our discussions we can add the new field if it makes sense. Thanks @sampaiodiego !