Skip to content
This repository was archived by the owner on Nov 5, 2025. It is now read-only.

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Feb 8, 2021

What? β›΅

Some permission checkers for the Livechat bridge are missing, causing runtime errors

Why? πŸ€”

Links 🌎

PS πŸ‘€

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #379 (903dd79) into master (ea8c07f) will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   50.31%   49.63%   -0.69%     
==========================================
  Files         108      100       -8     
  Lines        3309     3145     -164     
  Branches      461      463       +2     
==========================================
- Hits         1665     1561     -104     
+ Misses       1644     1584      -60     
Impacted Files Coverage Ξ”
...ver/permissions/checkers/AppDetailChangesBridge.ts 0.00% <0.00%> (-50.00%) ⬇️
...c/server/permissions/checkers/AppLivechatBridge.ts 7.69% <0.00%> (-1.62%) ⬇️
src/server/bridges/index.ts
src/server/marketplace/license/index.ts
src/server/logging/index.ts
src/server/accessors/index.ts
src/server/managers/index.ts
src/server/compiler/index.ts
src/server/storage/index.ts
src/server/errors/index.ts
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update a1507d2...903dd79. Read the comment docs.

Copy link
Contributor

@thassiov thassiov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-gubert d-gubert changed the title Add missing permission checkers Fix missing permission checkers Feb 8, 2021
@d-gubert d-gubert merged commit 8dd5129 into master Feb 8, 2021
@d-gubert d-gubert deleted the hotfix/livechat-permission-checkers branch February 8, 2021 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants