Rergession: Change file content from stream to Buffer

[d-gubert]

What? ⛵

See title

Why? 🤔

Providing a stream so apps can access the file content would break the functionality, as once the stream has finished emitting data, it's not possible to rewind it. This would mean that whenever an app reads the contents of the stream, any subsequent app, and even Rocket.Chat, would not be able to do so.

Changing it to a Buffer allows all parties to read the contents of the file.

[codecov]

Codecov Report

Merging #376 (670d4e6) into alpha (52ab716) will increase coverage by 0.55%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            alpha     #376      +/-   ##
==========================================
+ Coverage   49.76%   50.31%   +0.55%     
==========================================
  Files         100      108       +8     
  Lines        3137     3309     +172     
  Branches      460      461       +1     
==========================================
+ Hits         1561     1665     +104     
- Misses       1576     1644      +68     

Impacted Files	Coverage Δ
.../server/permissions/checkers/AppSchedulerBridge.ts	25.00% <0.00%> (-17.86%)	⬇️
src/server/errors/PermissionDeniedError.ts	20.00% <0.00%> (-80.00%)	⬇️
src/server/compiler/modules/net.ts	50.00% <0.00%> (-50.00%)	⬇️
...c/server/permissions/checkers/AppInternalBridge.ts	20.00% <0.00%> (-30.00%)	⬇️
...issions/checkers/AppEnvironmentalVariableBridge.ts	30.76% <0.00%> (-29.24%)	⬇️
src/server/permissions/checkers/AppApisBridge.ts	36.36% <0.00%> (-26.14%)	⬇️
...ver/permissions/checkers/AppUiInteractionBridge.ts	44.44% <0.00%> (-22.23%)	⬇️
...server/permissions/checkers/AppActivationBridge.ts	11.11% <0.00%> (-22.23%)	⬇️
src/server/permissions/checkers/AppUploadBridge.ts	25.00% <0.00%> (-21.16%)	⬇️
src/server/permissions/checkers/AppHttpBridge.ts	57.14% <0.00%> (-17.86%)	⬇️
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52ab716...670d4e6. Read the comment docs.