Enable Apps to create rooms without assigning a creator manually

[d-gubert]

What? ⛵

Currently, when an app wants to create a room, it is required that it provides a user to be assigned as the room creator.
This PR removes such requirement, assigning the app's default user if no other user has been provided for room creation.

Why? 🤔

Removing barriers to getting things done usually improves developer experience :)

Links 🌎

PS 👀

[d-gubert]

@sampaiodiego do you see any problems in making this easier? Any negative impact on the usability of the product?

[codecov]

Codecov Report

Merging #230 into beta will increase coverage by 1.99%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             beta     #230      +/-   ##
==========================================
+ Coverage   53.81%   55.80%   +1.99%     
==========================================
  Files          70       78       +8     
  Lines        2568     2686     +118     
  Branches      380      381       +1     
==========================================
+ Hits         1382     1499     +117     
- Misses       1186     1187       +1     

Impacted Files	Coverage Δ
src/server/errors/index.ts	100.00% <0.00%> (ø)
src/server/compiler/index.ts	100.00% <0.00%> (ø)
src/server/logging/index.ts	100.00% <0.00%> (ø)
src/server/storage/index.ts	100.00% <0.00%> (ø)
src/server/accessors/index.ts	100.00% <0.00%> (ø)
src/server/marketplace/license/index.ts	100.00% <0.00%> (ø)
src/server/bridges/index.ts	100.00% <0.00%> (ø)
src/server/managers/index.ts	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c4e8e...b70292c. Read the comment docs.

[sampaiodiego]

need to test what happens to the rooms created by the app user when the app is uninstalled.. we have a policy to not allow a room without an owner, so I think you'll not be able to uninstall the app.

[sampaiodiego]

besides that, I think it is a good change 👍

[d-gubert]

need to test what happens to the rooms created by the app user when the app is uninstalled.. we have a policy to not allow a room without an owner, so I think you'll not be able to uninstall the app.

Well, that is a major blocker for this 😅 It doesn't look like there is an easy way out - Maybe we could alert the admin upon uninstallation that "It's not possible to uninstall this app because the app user is still the owner of some rooms. We've disabled the app for now, please check the rooms and manually remove them or change the owner before trying to uninstall again".

What do you think?

[sampaiodiego]

maybe we should wait for RocketChat/Rocket.Chat#16088 to decide what to do, as it will change the current behavior.