-
Notifications
You must be signed in to change notification settings - Fork 120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 55.42% 55.51% +0.09%
==========================================
Files 68 68
Lines 2396 2401 +5
Branches 360 360
==========================================
+ Hits 1328 1333 +5
Misses 1068 1068
Continue to review full report at Codecov.
|
graywolf336
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it overall. I understand this is just for slash commands, but is the thread id now being sent as part of the regular messages? Aka will the MessageSent events which are fired include the thread id?
|
Yes, now they include the I've opted to not send the actual thread message object as this would add another trip to the db, and then if some app needs the data from the thread message they can call |
|
Wonder if we should add documentation to the property about that, that way people don't have to searching through issues and pull requests to get that information. |
|
|
||
| /** | ||
| * Retrieves the thread to which this message belongs, | ||
| * if any. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * if any. | |
| * if any. Use the message reader to get the thread's message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated it (see below). WDYT? 😛
Apps will need to update their slash commands for them to send messages correctly aware of the thread.
Implementation provided by RocketChat/Rocket.Chat#15574