Fix tf listener in rai_sim module #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Jaroszek <[email protected]>
|
@pijaro Thank you for this fix! I tested it and the issue no longer occurs. @maciejmajek @rachwalk Since I am not very familiar with connectors, I will leave the code review to someone more knowledgeable on the subject. |
maciejmajek
approved these changes
Feb 20, 2025
Member
maciejmajek
left a comment
maciejmajek
left a comment
There was a problem hiding this comment.
I think this actually makes sense. Can't test it until Monday, but i believe it should work as intended/better with this change
maciejmajek
pushed a commit
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Piotr Jaroszek <[email protected]>
MagdalenaKotynia
pushed a commit
that referenced
this pull request
Feb 26, 2025
Signed-off-by: Piotr Jaroszek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes ROS 2 executor random crashes.
Proposed Changes
Move TF buffer to node scope.
Issues
Testing