Implement Ros2PublishRadarScanNode with tests#247
Merged
Conversation
prybicki
force-pushed
the
feature/radar-node
branch
from
ec91ae7 to
e0057c6
Compare
msz-rai
suggested changes
Jan 29, 2024
Contributor
msz-rai
left a comment
msz-rai
left a comment
There was a problem hiding this comment.
Good job 👍
I have left some comments to address.
Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com>
msz-rai
added a commit
that referenced
this pull request
Jun 11, 2024
* Implement Ros2PublishRadarScanNode * Add test for Ros2PublishRadarScanNode * Fix copyright year * Add API Call * Apply suggestions from code review Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com> * Review fixes --------- Co-authored-by: Mateusz Szczygielski <112629916+msz-rai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.