-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added canvas as option to the viewer #584
base: develop
Are you sure you want to change the base?
Conversation
Hi @MatthijsBurgh, could you please review this PR at your convenience? Thanks. |
@MatthijsBurgh Appreciate all the suggestions! Made the modifications and please help review it at your convenience. Thanks! |
@Techming could you please edit your first commit to exclude the changes in the build folder? |
@MatthijsBurgh Sorry about that. Reverted build files to the previous commit. (Apologies for the typo in the commit message) |
@Techming there are 2 test folders. One is just for running manually in your browser. The other one is running in CI too. You didn't add the test there. I did add it there. Now CI fails. |
I’m working on identifying the issue and wrote additional tests to make sure the Viewer itself can pass the CI test. Could you help approve the workflow? Thanks. @MatthijsBurgh |
From the CI error log it seems that the Viewer class fails the CI without canvas passed in as the param. I will confirm locally if the changes of in my code have effects on the result. @MatthijsBurgh |
Public API Changes
The Viewer constructor now accepts
canvas
as an option in the parameter options.Description
This is built upon PR #549 which will be closed when this PR opens.
#546