Give ability to bind SparseVector
#70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Do you have example drake PR that shows this failing?
Also, if we'd want this to land, we'd want to add testing, ideally representative of what you encountered.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
|
Drake policy re: this repository has changed over time. We have a goal of using vanilla upstream pybind11 (and eventually, nanobind). As such, we should strongly disprefer adding any patches here -- instead, we should add code into Drake that meets the need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that currently it is not possible to bind Drake methods which output a
SparseVectorbecause "there is no notion of compressed/uncompressed mode for a SparseVector".This is a small fix attempting to fix this, but I am not familiar with this repository so don't know how to test this nor upgrade Drake with the fix.
cc @EricCousineau-TRI since you seem to be the maintainer
This change is