1.0 Bindings #50
Merged
1.0 Bindings #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the check for group level network configs so that the recommended job spec with networking on Nomad v1.0+ works. There is also backwards compatibility functionality for the deprecated network ports, however you can not / should not mix and match between deprecated configs and recommended ones. The 1st party docker driver implements bindings in a similar way.
Removed
resource_portas a config and migrated the functionality toportas a setting. This keeps it on a similar page as other drivers and should help folks understand what needs to be set and not be confused about theportnumber config (which we now rely on Nomad providing that for us).Fix #43