Reducing complexity to 16

[pullfrog]

Closes #3337

Lowers the ESLint complexity rule threshold from 18 to 16 for express-zod-api/src/*.ts.

Two functions exceeded the new limit at complexity 17 and were refactored by extracting helpers:

• documentation-helpers.ts: extracted getLocation() from the depictRequestParams reduce callback
• json-schema-helpers.ts: extracted mergeExamples() from flattenIO

Both extractions are pure refactors with no behavioral changes. All tests pass (864 unit tests + integration suites).

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[coveralls-official]

coverage: 100.0%. remained the same — pullfrog/3337-reduce-complexity-to-16 into master

[pullfrog]

Addressed review feedback: marked mergeExamples as /** @internal */, exported it, and added 5 unit tests covering all branches (no examples, optional concat, optional init, required combinations, required init). All 869 tests pass.

Task list (3/3 completed)

• Mark mergeExamples as @internal and export it
• Add unit tests for mergeExamples
• Commit, push, reply to review

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

Addressed review feedback: combined the two nearly identical mergeExamples tests ("should initialize examples when optional and flat has none" and "should handle required with no prior examples") into a single test.each([true, false]) parameterized test. All 37 tests pass.

Task list (3/3 completed)

• Combine similar tests using test.each() per reviewer feedback
• Run tests to verify changes
• Commit, push, reply to review comment, resolve thread

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

Renamed the flat parameter to target in mergeExamples as requested. All 37 json-schema-helpers tests pass. Pushed and resolved the thread.

Task list (3/4 completed)

• Rename flat parameter to target in mergeExamples function
• Update all usages of flat inside mergeExamples body
• Update test references if any use the parameter name
• Run tests, commit, push, and reply to review comment

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

Inlined isPathParam and isHeaderParam into getLocation as an if..return sequence per review feedback. Pushed and resolved the thread.

Task list (3/3 completed)

• Inline isPathParam and isHeaderParam into getLocation as if..return..else..return
• Run tests to verify correctness
• Commit, push, reply to review, resolve thread

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[RobinTail]

LGTM 👍🏽

related to #3331 and #3329

[pullfrog]

Removed the redundant return undefined from getLocation in documentation-helpers.ts as requested. All 869 tests pass. Pushed and resolved the thread.

Task list (4/4 completed)

• Read the relevant code and understand the reviewer's feedback
• Remove the redundant return undefined statement
• Run tests to verify the change
• Commit, push, and reply to the review comment

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

Addressed review feedback: removed the explicit type annotation (which had {} triggering an eslint warning) and switched the assertion to .toHaveProperty("examples", [...]). All 37 tests in json-schema-helpers.spec.ts pass. Changes pushed and thread resolved.

Task list (4/4 completed)

• Read the test code at the commented line and understand the feedback
• Apply the fix: remove inline type annotation and use .toHaveProperty assertion
• Run tests to verify changes
• Commit, push, reply to review comment

  ^{｜ View workflow run ｜ via Pullfrog ｜ Using Claude Opus ｜ 𝕏}