-
-
Notifications
You must be signed in to change notification settings - Fork 35
Exp: Improving final intersection #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
In favor of #2762 |
…2762) Fixes #2760 Alternative implementation to #2761 I like this one more for being more explicit. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Enhanced support for optional input schemas, allowing endpoints to handle undefined input schemas for greater flexibility. - **Bug Fixes** - Improved handling of excessive properties in input objects, ensuring correct stripping or retention based on schema configuration. - Fixed TypeScript typing for unknown properties in input schemas, preventing incorrect `never` types. - **Tests** - Added and refined tests to verify input property handling and stricter type equality for input schema intersections. - **Documentation** - Updated contributors list to include a new contributor. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Fixes #2760 , but I don't entirely like it