Renaming ez.file() to ez.download()
#2667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
added
refactoring
RobinTail
commented
May 26, 2025
RobinTail
commented
May 26, 2025
| export const ezRawBrand = Symbol("Raw"); | ||
|
|
||
| const base = z.object({ raw: file("buffer") }); | ||
| const base = z.object({ raw: download("buffer") }); |
Owner
Author
There was a problem hiding this comment.
should address buffer schema directly
RobinTail
commented
May 26, 2025
Owner
Author
RobinTail
left a comment
RobinTail
left a comment
There was a problem hiding this comment.
perhaps, it would be even better to remove ez.file() completely, but expose the buffer schema with a suggestion to use .meta() for setting customized props depending on particular needs.
Owner
Author
|
Doing #2668 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm addressing the possible confusion between
ez.file()and the new schema of Zod 4z.file().The proprietary one is designed for depicting file content in response having the form of string or a buffer.
For the sake of consistency with
ez.upload()I'm renaming it toez.download().