-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proprietary schemas using native zod methods and Metadata #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
added
enhancement
New feature or request
refactoring
The better way to achieve the same result
miracle
Mysterious events are happening here
labels
Jan 4, 2024
RobinTail
changed the title
Experiment: proprietary schemas using
Experiment: proprietary schemas using native methods and metadata
Jan 5, 2024
z.custom()
and metadata
RobinTail
commented
Jan 5, 2024
RobinTail
commented
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm happy with it
RobinTail
changed the title
Experiment: proprietary schemas using native methods and metadata
Proprietary schemas using native zod methods and Metadata
Jan 8, 2024
I consider the experiment successful. |
Time for a beta |
✅ Regression test passed |
RobinTail
commented
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
miracle
Mysterious events are happening here
refactoring
The better way to achieve the same result
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was dreaming about it.
Unfortunately
zod
does not provide any way to make a custom or branded or third-party schema that can be identified as one programmatically. Developer ofzod
also does not want to make any method to store metadata in schemas, instead, recommends to wrap schemas in some other structures, which is not suitable for the purposes ofexpress-zod-api
. There are many small inconvenient things in making custom schema classes, that I'd like to replace into native methods, and usewithMeta
wrapper for storing proprietary identifier, so the generators and walkers could still handle it.Related issues:
PR I've been waiting for months to merged (programmatically distinguishable branding):