feat: bundle pyright inside wheel #300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertCraigie
force-pushed
the
feat/nodejs-extra
branch
2 times, most recently
from
d221beb
to
407f2a5
Compare
RobertCraigie
force-pushed
the
feat/bundle-pyright
branch
6 times, most recently
from
f4fe729
to
32f626e
Compare
RobertCraigie
force-pushed
the
feat/bundle-pyright
branch
3 times, most recently
from
4e13c53
to
40cbf39
Compare
add test for bundled version fix fix fix fix fix
RobertCraigie
force-pushed
the
feat/bundle-pyright
branch
from
40cbf39
to
7815db2
Compare
Bibo-Joshi
added a commit
to Bibo-Joshi/chango
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #231
My main concern with this change is that it increases the footprint of this package by a considerable margin, both over-the-wire bytes and disk storage needed as there is no per-machine cache anymore, the files
pyrightneeds to run will be duplicated for each project.I think this is a fairly marginal concern though, if users report any issues about the package size I'd be investigate publishing a separate
pyright-slim(or similar) package that retains the non-bundled behaviour.TODO: fix nodejs_wheel debug log
TODO: let conda maintainer know about this change #102