Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): force utf-8 in setup #491

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

tyteen4a03
Copy link
Contributor

Change Summary

Changes setup.py to always open files in UTF-8 encoding to avoid weird encoding errors when installing the package.

Checklist

N/A

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #491 (8f844eb) into main (1fb27b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files         120      120           
  Lines        6015     6015           
  Branches     1022     1022           
=======================================
  Hits         5668     5668           
  Misses        305      305           
  Partials       42       42           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RobertCraigie RobertCraigie changed the title fix: force utf-8 in setup fix(package): force utf-8 in setup Sep 17, 2022
@RobertCraigie RobertCraigie merged commit 8fbe15a into RobertCraigie:main Sep 17, 2022
@RobertCraigie
Copy link
Owner

Thank you! 💜

@tyteen4a03 tyteen4a03 deleted the fix/utf8-setup branch September 17, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants