Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add root support for filtering by None #362

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

RobertCraigie
Copy link
Owner

@RobertCraigie RobertCraigie commented Apr 12, 2022

Change Summary

Closes #331.

I've only added root support for querying by None as adding that to sub filters is a much bigger task.

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #362 (0dce5f8) into main (59847ca) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   96.52%   96.58%   +0.06%     
==========================================
  Files         113      113              
  Lines        5639     5747     +108     
  Branches      324      325       +1     
==========================================
+ Hits         5443     5551     +108     
  Misses        147      147              
  Partials       49       49              
Impacted Files Coverage Δ
src/prisma/generator/models.py 91.96% <100.00%> (+0.03%) ⬆️
tests/test_types/test_bigint.py 100.00% <100.00%> (ø)
tests/test_types/test_bool.py 100.00% <100.00%> (ø)
tests/test_types/test_bytes.py 100.00% <100.00%> (ø)
tests/test_types/test_datetime.py 100.00% <100.00%> (ø)
tests/test_types/test_decimal.py 100.00% <100.00%> (ø)
tests/test_types/test_float.py 100.00% <100.00%> (ø)
tests/test_types/test_int.py 100.00% <100.00%> (ø)
tests/test_types/test_string.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59847ca...0dce5f8. Read the comment docs.

@RobertCraigie RobertCraigie merged commit 7c6e796 into main Apr 12, 2022
@RobertCraigie RobertCraigie deleted the feat/filter-nulls branch April 12, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for filtering by null values
1 participant