Update breaks Ember builds for Ember 3.7

[Redsandro]

I can't provide a range of versions so I don't know up until which version this error occurs, but for Ember 3.7 you'll need ember-math-helpers <= 2.10.0.

Ember installations with ember-math-helpers in package.json configured as ^2.10.0 will break when doing a fresh npm install.

Build Error (broccoli-persistent-filter:Babel > [Babel: ember-math-helpers]) in ember-math-helpers/helpers/abs.js

Cannot read property 'getHash' of null

[RobbieTheWagner]

@Redsandro the tests are passing back to Ember 3.4 https://travis-ci.org/shipshapecode/ember-math-helpers, so I think there may be more at play here and/or there is something about 3.7 specifically that doesn't work.

[Redsandro]

@rwwagner90 Possibly. I can't figure out why this is happening though. Does the message "Cannot read property 'getHash' of null" ember-math-helpers/helpers/abs.js give you any idea about where I should be looking?

[RobbieTheWagner]

It does not. There is nothing in https://github.com/shipshapecode/ember-math-helpers/blob/master/addon/helpers/abs.js that uses anything called getHash. Is it possible to get a small, isolated reproduction we could look at? It's also possible there was a bug in Ember itself in 3.7. Would you be able to use 3.8?

[Redsandro]

Sorry for not getting back to you earlier. I was traveling. This is definitely still an issue and it's weird that I can get it to work by downgrading ember-math-helpers.

I'm a long time Linux user, but Ember feels a bit like Windows in the old days, where over time, updates cause more and more inexplicable errors to the point of needing a fresh install.

With Ember Octane out, I think it might be time to do a 'fresh install'.

I will close this issue for now.

[RobbieTheWagner]

@Redsandro if you can reproduce in a small, self contained, app, let me know.

[iamareebjamal]

Happening for us as well

ERROR Summary:

  - broccoliBuilderErrorStack: TypeError: Cannot read property 'getHash' of null
    at hashForDep (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/hash-for-dep/index.js:67:24)
    at optionsHash (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/lib/options-hash.js:58:51)
    at Babel.optionsHash (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/index.js:117:26)
    at Babel.cacheKeyProcessString (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/index.js:124:15)
    at Object.processString (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/lib/strategies/persistent.js:30:19)
    at Processor.processString (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/lib/processor.js:19:27)
    at /home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/index.js:353:16
    at initializePromise (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/node_modules/rsvp/dist/rsvp.js:520:5)
    at new Promise (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/node_modules/rsvp/dist/rsvp.js:995:33)
    at invoke (/home/iamareebjamal/git/open-event-frontend/node_modules/broccoli-babel-transpiler/node_modules/broccoli-persistent-filter/index.js:352:10)
  - code: [undefined]
  - codeFrame: Cannot read property 'getHash' of null
  - errorMessage: ember-math-helpers/helpers/abs.js: Cannot read property 'getHash' of null
        in /tmp/broccoli-27396gIn7cjRKlxLh/out-457-funnel_funnel_addon_js
        at broccoli-persistent-filter:Babel > [Babel: ember-math-helpers] (Babel: ember-math-helpers)
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: ember-math-helpers/helpers/abs.js
    - line: [undefined]
    - treeDir: /tmp/broccoli-27396gIn7cjRKlxLh/out-457-funnel_funnel_addon_js
  - message: ember-math-helpers/helpers/abs.js: Cannot read property 'getHash' of null
        in /tmp/broccoli-27396gIn7cjRKlxLh/out-457-funnel_funnel_addon_js
        at broccoli-persistent-filter:Babel > [Babel: ember-math-helpers] (Babel: ember-math-helpers)
  - name: BuildError
  - nodeAnnotation: Babel: ember-math-helpers
  - nodeName: broccoli-persistent-filter:Babel > [Babel: ember-math-helpers]
  - originalErrorMessage: Cannot read property 'getHash' of null

[RobbieTheWagner]

@iamareebjamal can you provide any details? Ember version, ember-cli version, custom broccoli stuff you might be doing, etc?

[iamareebjamal]

"ember-cli": "~3.10.1"

Using broccoli-persistent-filter

The project is open source. This is the PR - fossasia/open-event-frontend#3873

[RobbieTheWagner]

My guess would be something with broccoli, babel, or the htmlbars update, but I don't really know. I've been using it without any issues in several projects. It might be that you are using broccoli-funnel and this addon is not compatible with the version or something. @Redsandro thoughts?

[Redsandro]

One guess is that a certain dependency is too new. But I'm grasping straws, I couldn't figure it out.

v2.10.0...v2.11.0 see package.json

[iamareebjamal]

It's working for 2.11.1 for us. Breaking on latest

[iamareebjamal]

Starts breaking from 2.11.2