Fixed property from interface implemented by trait #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Days without bugs in property hooks: 0 |
|
The problem here is that BR looks for the property in interface first and completely skips the implementation in the used trait. |
kukulich
force-pushed
the
trait-interface-property
branch
from
45952b9 to
94b7e42
Compare
kukulich
changed the title
kukulich
force-pushed
the
trait-interface-property
branch
from
94b7e42 to
fedbd2a
Compare
kukulich
force-pushed
the
trait-interface-property
branch
from
fedbd2a to
8f5e710
Compare
Ocramius
approved these changes
Feb 12, 2025
|
Thanks @kukulich! |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.