Update russian spelling #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two similar but distinct adjectives in Russian, `русский` и `российский`. The former is used to refer to ethnicity/language/etc, and the latter is used to refer to the state/citizenship/etc (because historically Russia has been a multi-ethnic empire). Using `русским` was semantically wrong (reads as `To the ethnic Russian citizens (of an unknown country)`) and unnecessarily narrow at the same time.
|
Note: this is also on all |
Perhaps it should. |
|
Thanks @weirdan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two similar but distinct adjectives in Russian,
русскийироссийский. The former is used to refer to ethnicity/language/etc, and the latter is used to refer to the state/citizenship/etc (because historically Russia has been a multi-ethnic empire).Using
русскимwas semantically wrong (reads asTo the ethnic Russian citizens (of an unknown country)) and unnecessarily narrow at the same time.