Handle reflection error in retrieving default values #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielBadura
commented
Nov 25, 2022
src/DetectChanges/BCBreak/FunctionBased/ParameterDefaultValueChanged.php
Show resolved
Hide resolved
Ocramius
requested changes
Nov 25, 2022
src/DetectChanges/BCBreak/FunctionBased/ParameterDefaultValueChanged.php
Outdated
Show resolved
Hide resolved
src/DetectChanges/BCBreak/FunctionBased/ParameterDefaultValueChanged.php
Show resolved
Hide resolved
test/unit/DetectChanges/BCBreak/FunctionBased/ParameterDefaultValueChangedTest.php
Show resolved
Hide resolved
DanielBadura
force-pushed
the
handle-new-and-enum
branch
from
9984489
to
cc5db34
Compare
|
Psalm seems for now not fixable since it complaining about undefined vars after the foreach but there is no possible case imho. PHPcs will be fixed in the next commit round and infection as soon as we are finished polishing the behaviour. |
Ocramius
reviewed
Nov 28, 2022
src/DetectChanges/BCBreak/FunctionBased/ParameterDefaultValueChanged.php
Show resolved
Hide resolved
DanielBadura
force-pushed
the
handle-new-and-enum
branch
from
cc5db34
to
209091c
Compare
|
@Ocramius could you have a look again on this PR? Psalm errors were not fixable for me without defining the variables with |
Ocramius
approved these changes
Feb 10, 2023
|
Ah, one last thing: we'll need to rebase due to the |
…nd also using an enum as default value.
DanielBadura
force-pushed
the
handle-new-and-enum
branch
from
b475797
to
483cd59
Compare
|
@Ocramius PR is now rebased 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #698
This is the first PoC of handling the two errors mentioned in the linked issue. I added a TestCase for both errors. I'm not sure what exactly we should compare from the AST of the two parameters so for now only checking if the type is the same which already resolved the error case.