Skip to content

Commit

Permalink
Merge pull request #724 from Roave/fix/#723-ignore-internal-method-bc…
Browse files Browse the repository at this point in the history
…-issues-also-on-final-classes

Fix #723 by ignoring BC issues on `@internal` methods of `final` classes
  • Loading branch information
Ocramius authored Dec 21, 2022
2 parents 4a98f2f + dbf3442 commit 9deff3c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bin/roave-backward-compatibility-check.php
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ static function (string $installationPath) use ($composerIo): Installer {
)),
)),
new ClassBased\SkipClassBasedErrors(new ClassBased\MethodChanged(
new MethodBased\SkipMethodBasedErrors(new MethodBased\OnlyPublicMethodChanged(
new MethodBased\SkipMethodBasedErrors(new MethodBased\OnlyPublicMethodChanged(new MethodBased\ExcludeInternalMethod(
new MethodBased\MultipleChecksOnAMethod(
new MethodBased\SkipMethodBasedErrors(new MethodBased\MethodBecameFinal()),
new MethodBased\SkipMethodBasedErrors(new MethodBased\MethodConcretenessChanged()),
Expand All @@ -226,7 +226,7 @@ static function (string $installationPath) use ($composerIo): Installer {
),
)),
),
)),
))),
)),
),
)),
Expand Down

0 comments on commit 9deff3c

Please sign in to comment.