Resolves Issue 20 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #20. It needs to be tagged as v0.2.1, and the release notes copied into the guthub releases page.
I moved processes creation to init() time, eliminated the auto_connect() thread, and moved auto_connect logic to the start of the _comm process. auto_connect() now simply sets a shared memory flag to signal _comm to start the connection process. Threads for state_transition_func and update_data_func callbacks are created when the client calls freshroastsr700.auto_connect(), well after the _comm and _timer processes are spawned, which preserves the ability to pickle freshroastsr700 when the processes spawn.