-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
croaring 2.0 yanked? #136
Comments
Sorry for the misunderstanding @damageboy , there's a critical issue in CRoaring that made us yank the 2.0 release. Since there's a fix pr, I expect it will get merged soon and we can release In terms of versioning - new major version is released whenever there is a breaking change. Minor versions are for backwards compatible bug fixes and new features. |
Add some tests which will fail until we get a 4.0.1 of CRoaring. Don't merge until we update again once CRoaring is fixed. Also, include the matching CRoaring version in the readme and some clarification on versioning, this will hopefully help clarify somewhat the questions raised in #136. Link to the rendered added section: https://github.com/Dr-Emann/croaring-rs/blob/2_0_for_real/README.md#croaring-version
Version 2.0.2 is on crates.io now as the first non-yanked 2.x croaring-rs release. I've hopefully clarified in the README to both include the version of CRoaring we build with, and to explain why we don't match the major version (because breaking changes in CRoaring have often not required breaking changes in the idiomatic rust bindings). However, we are now mirroring the CRoaring version in the croaring-sys crate. |
Hi,
It seems like the officially tagged release is 2.0 while this is the situation on crates.io:
Can someone from the project provide a clarification of the state of 2.0, is it brandishing a croaring 3.0 / 4.0 and what is exactly the release status.
Also, I personally think it would greatly add / improve clarity of the versioning would follow croraring major versioning at the least so that users clearly understand what they are getting...
The text was updated successfully, but these errors were encountered: