Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

croaring 2.0 yanked? #136

Closed
damageboy opened this issue Jun 30, 2024 · 2 comments · Fixed by #137
Closed

croaring 2.0 yanked? #136

damageboy opened this issue Jun 30, 2024 · 2 comments · Fixed by #137

Comments

@damageboy
Copy link

Hi,
It seems like the officially tagged release is 2.0 while this is the situation on crates.io:

image

Can someone from the project provide a clarification of the state of 2.0, is it brandishing a croaring 3.0 / 4.0 and what is exactly the release status.

Also, I personally think it would greatly add / improve clarity of the versioning would follow croraring major versioning at the least so that users clearly understand what they are getting...

@saulius
Copy link
Member

saulius commented Jul 1, 2024

Sorry for the misunderstanding @damageboy , there's a critical issue in CRoaring that made us yank the 2.0 release. Since there's a fix pr, I expect it will get merged soon and we can release 2.x version of croaring-rs with a fix.

In terms of versioning - new major version is released whenever there is a breaking change. Minor versions are for backwards compatible bug fixes and new features. croaring-rs does not explicitly follow CRoaring in terms of version numbers.

@Dr-Emann Dr-Emann mentioned this issue Jul 1, 2024
Dr-Emann added a commit that referenced this issue Jul 4, 2024
Add some tests which will fail until we get a 4.0.1 of CRoaring. Don't merge until we update again once CRoaring is fixed.

Also, include the matching CRoaring version in the readme and some clarification on versioning, this will hopefully help clarify somewhat the questions raised in #136. Link to the rendered added section: https://github.com/Dr-Emann/croaring-rs/blob/2_0_for_real/README.md#croaring-version
@Dr-Emann
Copy link
Member

Dr-Emann commented Jul 8, 2024

Version 2.0.2 is on crates.io now as the first non-yanked 2.x croaring-rs release.

I've hopefully clarified in the README to both include the version of CRoaring we build with, and to explain why we don't match the major version (because breaking changes in CRoaring have often not required breaking changes in the idiomatic rust bindings).

However, we are now mirroring the CRoaring version in the croaring-sys crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants