disabling AVX routines under Visual Studio #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dr-Emann I don't want to do this, but if Microsoft cannot support AVX properly, there is little we can do. |
|
Unfortunately, agreed. |
Dr-Emann
approved these changes
Mar 1, 2024
Dr-Emann
reviewed
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Visual Studio's last few C++ compilers (starting with VS 17.8), you can write code that relies solely on AVX2, and it may compile to AVX-512 instructions. See screenshot.
Related problems were reported to Microsoft by several folks and reportedly fixed in 17.9, but according to our tests, it is not fixed.
This is a critical issue that can lead to crashing software. Unfortunately, you may not see it until you test it on hardware that does not support AVX-512.
Thus, we are disabling AVX optimizations on recent Visual Studio C++ compilers.
Related threads/findings:
Original find
Microsoft bug report