Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize C++ roaring64 contains and addMany #586

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Optimize C++ roaring64 contains and addMany #586

merged 1 commit into from
Feb 8, 2024

Conversation

mapleFU
Copy link
Contributor

@mapleFU mapleFU commented Feb 5, 2024

This patch contains two simple optimizations:

  1. For Roaring64Map::addMany(uint64_t), trying to use BulkContext to cache the last context
  2. For Roaring64Map::contains, change count + at to find

Dr-Emann
Dr-Emann approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@Dr-Emann Dr-Emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this all makes sense to me

@mapleFU
Copy link
Contributor Author

mapleFU commented Feb 8, 2024

Can we merge this or wait other to review this patch?

@lemire
Copy link
Member

lemire commented Feb 8, 2024

Merging.

@lemire lemire merged commit 04c9af2 into RoaringBitmap:master Feb 8, 2024
20 checks passed
@mapleFU mapleFU deleted the roaring-minor-optimizations branch February 18, 2024 05:11
@BrewTestBot BrewTestBot mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Emann Dr-Emann Dr-Emann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapleFU @lemire @Dr-Emann