Fix double free in roaring64 andnot_inplace #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
container_iandnot frees the original container if necessary. Interestingly, as far as I can tell container_iand does not. Added a test for both.
|
It seems like this documentation for CRoaring/include/roaring/containers/containers.h Lines 1962 to 1963 in f3ad2f2 (or maybe reworded, is it saying "if it returns a different pointer, it's a new container, and so should be freed at some point?") |
In contrast to other in-place functions, which don't free the original if a different type of container is created.
Dr-Emann
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555
container_iandnotfrees the original container if necessary. Interestingly, as far as I can tellcontainer_ianddoes not. Added a test for both.