Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roaring64: container_add_range _is_ inclusive #551

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Conversation

Dr-Emann
Copy link
Member

container_add_range is from [min, max], no need to add one:

* Add all values in range [min, max] to a given container.

Add a test to verify adding a range to an existing container works correctly

@Dr-Emann Dr-Emann requested a review from SLieve January 13, 2024 21:48
@Dr-Emann Dr-Emann changed the title container_add_range _is_ inclusive roaring64: container_add_range _is_ inclusive Jan 13, 2024
Copy link
Contributor

@SLieve SLieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where I went wrong. Looks good, thanks!

@Dr-Emann Dr-Emann merged commit c3becfe into master Jan 14, 2024
44 checks passed
@Dr-Emann Dr-Emann deleted the push-zyqrwyvrqlsr branch January 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants