Removing a static qualifier #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
reviewed
Jul 4, 2023
| @@ -180,7 +180,7 @@ extern "C" { // portability definitions are in global scope, not a namespace | |||
|
|
|||
| /* wrappers for Visual Studio built-ins that look like gcc built-ins __builtin_ctzll */ | |||
| /* result might be undefined when input_num is zero */ | |||
| static inline int roaring_trailing_zeroes(unsigned long long input_num) { | |||
| inline int roaring_trailing_zeroes(unsigned long long input_num) { | |||
There was a problem hiding this comment.
If we remove static, but leave it inline, we should add an extern inline to a .c file, or e.g. calling it directly in debug mode will fail with a linker error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495