portability.h: add an build flag to suppress warnings #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building CRoaring without support for atomics (for instance, in a pre-C11 environment where <stdatomic.h> is not part of the language specification), we get a compile-time message that copy-on-write bitmaps are unavailable. Having a warning message is useful as a default behavior, since it can prevent surprises for CRoaring users who expect their bitmaps to be thread-safe, but aren't for whatever reason. But in environments where we know that <stdatomic.h> is unavailable, or we are single-threaded, the message is noise, since we know ahead of time that CRoaring's bitmaps won't be threadsafe (and are OK with that). Provide an opt-out build knob (CROARING_SILENT_BUILD) to suppress this warning for applications that wish to do so. Signed-off-by: Taylor Blau <[email protected]>
|
Totally reasonable. Running tests to be sure. |
|
Will merge after all tests pass (and they will pass). |
|
Merging. |
|
As a note, this was already possible by explicitly defining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building CRoaring without support for atomics (for instance, in a pre-C11 environment where <stdatomic.h> is not part of the language specification), we get a compile-time message that copy-on-write bitmaps are unavailable.
Having a warning message is useful as a default behavior, since it can prevent surprises for CRoaring users who expect their bitmaps to be thread-safe, but aren't for whatever reason.
But in environments where we know that <stdatomic.h> is unavailable, or we are single-threaded, the message is noise, since we know ahead of time that CRoaring's bitmaps won't be threadsafe (and are OK with that).
Provide an opt-out build knob (CROARING_SILENT_BUILD) to suppress this warning for applications that wish to do so.