add command palette, add disable global #288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+394
to
+402
| { | ||
| id: "disable-global-trigger", | ||
| name: "Disable Global Node Menu Trigger", | ||
| action: { | ||
| type: "switch", | ||
| }, | ||
| description: | ||
| "Whether to disable the global trigger for the Discourse Node Menu, found at [[roam/js/discourse-graph]], and use the custom trigger instead", | ||
| }, |
There was a problem hiding this comment.
Why have a disable setting over just the custom trigger setting (where empty/obscure string effectively disables)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\is often used in LaTeX so users want the ability to disable it as the global node menu trigger.I'd probably like to phase out the global trigger in favor of the command palette, but I worry that users will request a "modifier" free option, which I don't think the command palette supports.
https://www.loom.com/share/d1ab1bb4e75446aebdb186fe39dccf5b