Comment out @import for Noto Sans in CommentSection.css (Fixes PostCSS build issues) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR removes the @import statement for Noto Sans in CommentSection.css by commenting it out. In some PostCSS configurations, having @import in the middle of the CSS caused build warnings or errors.
Instead, I'm suggesting that developers using this library should load the Noto Sans font on their own. For example:
In the HTML head:
Or in a global CSS file:
@import url('https://fonts.googleapis.com/css2?family=Noto+Sans&display=swap');
This approach prevents build conflicts and ensures the font is still available to users who need it. Please let me know if there's anything you'd like me to change.
Thank you!