Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

⚡️ New core trend indicator based on SSL Channel & Choppiness Index #195

Draft
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

Rikj000
Copy link
Owner

@Rikj000 Rikj000 commented Nov 17, 2021

New approach :

  • upward/downward based on SSLChannel + ATR
  • sideway based on Choppiness Indicator + Bollinger bands ratio

See Previous PR: #184 for test results that prove that this feature is beneficial to the framework.

@Rikj000 Rikj000 added the Feature - Enhancement Update or improvement to existing feature label Nov 17, 2021
@Rikj000 Rikj000 added this to the v0.13.0 milestone Nov 17, 2021
@Rikj000 Rikj000 self-assigned this Nov 17, 2021
@Rikj000
Copy link
Owner Author

Rikj000 commented Nov 17, 2021

☑️ We still need a way to automatically install pandas-ta before I can merge this feature in,
otherwise a lot of end-users will get stuck due to this dependency package not being included by default in Freqtrade.

🔲 Also we still need to clean-up the unused FreqUI-Plots

@Rikj000 Rikj000 added the In Progress This is being worked on label Nov 17, 2021
@Rikj000 Rikj000 marked this pull request as draft November 17, 2021 17:49
@Rikj000 Rikj000 marked this pull request as ready for review November 17, 2021 17:49
@Rikj000 Rikj000 marked this pull request as draft November 17, 2021 17:49
@3ylo
Copy link
Contributor

3ylo commented Nov 17, 2021

☑️ We still need a way to automatically install pandas-ta before I can merge this feature in, otherwise a lot of end-users will get stuck due to this dependency package not being included by default in Freqtrade.

🔲 Also we still need to clean-up the unused FreqUI-Plots

The framework changed quite a lot since we last had an indicator test, I will try to start one following some ideas, like the one the includes different sell indicators.
All ideas are welcome btw.

@briankudera
Copy link

briankudera commented Nov 17, 2021

☑️ We still need a way to automatically install pandas-ta before I can merge this feature in, otherwise a lot of end-users will get stuck due to this dependency package not being included by default in Freqtrade.

🔲 Also we still need to clean-up the unused FreqUI-Plots

I believe pandas-ta is now installed by default with Freqtrade?

@Rikj000
Copy link
Owner Author

Rikj000 commented Nov 17, 2021

I believe pandas_ta is now installed by default with Freqtrade?

Yes you are correct! 👀 Nice catch!
Then we should first update Freqtrade for MGM before we'll merge this feature in,
instead of doing a hacky implementation to add pandas-ta into Freqtrade's virtual environment.

@Rikj000 Rikj000 linked an issue Nov 17, 2021 that may be closed by this pull request
@Rikj000 Rikj000 added Planned Planned feature, improvement or bugfix (not being worked on yet) and removed In Progress This is being worked on labels Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature - Enhancement Update or improvement to existing feature Planned Planned feature, improvement or bugfix (not being worked on yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Fix bugs introduced by updating Freqtrade
4 participants