capi에서 설정 파일 로딩에 있는 버그를 고칩니다 #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
capi에서 설정 파일을 로딩하는데에는
Config::load_from_config_dir이 사용됩니다. 근데 이 함수에서는 이번에 새로 바뀐 설정 파일 레이아웃을 따라가지 않고 예전 EngineConfig을 사용하고 있습니다. 그래서 새 설정 파일을 읽지 못하고 항상 default 설정을 가져옵니다.이것을 고칩니다.
Note
설정 파일을 xdg config에서 읽어서 설정을 만드는 코드가 여러 군데에 파편화되어있는데 이걸 한 군데로 합쳐서 이런 버그가 안 생기게 하면 좋을 것 같습니다
Checklist