wayland: Don't bother to commit preedit text on deactivate #205
+1
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With input-method-unstable-v2, it's impossible to finish preedit texts
before deactivate.
I think this is a bug in IME. Focus changes deactivates the
input-method and I think there is no way to know it is going to be
deactivated in advance. Which means IME does not have chance to
commit string to old text-input. Also, by the protocol, there is no
way to distinguish the text-input behind. With these, I think IME
should reset their internal states (for example, to-be-committed
string) on deactivate. This is what my wlchewing does, and so it
does not have this bug.
@xdavidwu
Reference:
swaywm/sway#4932 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With input-method-unstable-v2, it's impossible to finish preedit texts before deactivate.
Reference