Make the access modifier for the client interface match the client #5195
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the `Client.Interface.liquid` template match the [`Client.Class.liquid`](https://github.com/RicoSuter/NSwag/blob/3cc1c36c7f9d632174bd6b478311879cb343251a/src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.liquid#L3) template. This will prevent CS0050 from occurring when the `clientClassAccessModifier` and `typeAccessModifier` settings are set to `internal`. Currently CS0050 is thrown when these settings are set to `internal` because the interface is `public` while the types in the method signatures are `internal`.
Author
Collaborator
|
Thanks for the suggestion, #4820 won here as it was first and also contains tests for the change. |
Author
Collaborator
|
My stock answer.. don't know about next release but you can always get a preview from MyGet... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
Client.Interface.liquidtemplate match theClient.Class.liquidtemplate. This will prevent CS0050 from occurring when theclientClassAccessModifierandtypeAccessModifiersettings are set tointernal.Currently CS0050 is thrown when these settings are set to
internalbecause the interface ispublicwhile the types in the method signatures areinternal.