Support C#11 required keyword in schema generation#1908
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 8, 2026
Merged
Support C#11 required keyword in schema generation#1908lahma merged 1 commit intoRicoSuter:masterfrom
lahma merged 1 commit intoRicoSuter:masterfrom
Conversation
…icoSuter#1672) Recognize RequiredMemberAttribute (C# required keyword) and JsonRequiredAttribute (STJ) when determining if a property should be marked as required in the generated schema. Also guard against null requiredAttribute in the MinLength logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lahma
force-pushed
the
fix/required-keyword-1879
branch
from
5f384d8 to
4cfeb3f
Compare
|
Thanks for doing that! |
This was referenced Apr 8, 2026
|
Hello, this change seem to have introduced an issue RicoSuter/NSwag#5359 |
This was referenced Apr 13, 2026
Owner
|
Yeah just was thinking about this, and was wondering whether this PR is really correct. C# required is not about nullable or JSON required but only says that the property needs to be set at creation time... maybe its conceptually wrong to assume required == property required (aka not nullable). These are the changes which needs to be done with extreme care... Not sure, maybe we need to revert this or make it opt-in /cc @lahma |
This was referenced Apr 13, 2026
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requiredkeyword were not marked as required in generated schemasRequiredMemberAttribute(C#requiredkeyword) andJsonRequiredAttribute(STJ) in bothSystemTextJsonReflectionServiceandNewtonsoftJsonReflectionServicerequiredAttributeinMinLengthlogic inJsonSchemaGenerator.AddPropertyTest plan
required string Name→ property is inRequiredProperties[JsonRequired] string Name→ property is inRequiredPropertiesrequired string Name→ property is inRequiredProperties🤖 Generated with Claude Code