Fix Display(Name) not setting schema title on classes#1906
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 8, 2026
Merged
Fix Display(Name) not setting schema title on classes#1906lahma merged 1 commit intoRicoSuter:masterfrom
lahma merged 1 commit intoRicoSuter:masterfrom
Conversation
lahma
force-pushed
the
fix/display-name-title-1776
branch
2 times, most recently
from
3a7c7fe to
8dc380b
Compare
Extract title from DisplayAttribute.GetName() in GenerateObject, mirroring the existing description extraction. Previously only worked on properties via ApplyDataAnnotations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lahma
force-pushed
the
fix/display-name-title-1776
branch
from
8dc380b to
fbc2ef3
Compare
This was referenced Apr 8, 2026
Merged
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Display(Name = "...")]on a class correctly setdescriptionbut ignoredNamefortitleDisplayAttribute.GetName()inGenerateObject, mirroring the existing description logic and the property-level pattern inApplyDataAnnotationsTest plan
When_class_has_Display_Name_then_schema_title_is_setverifying bothTitleandDescriptionare set🤖 Generated with Claude Code