Emit both JsonStringEnumMemberName and EnumMember attributes#1905
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 8, 2026
Merged
Emit both JsonStringEnumMemberName and EnumMember attributes#1905lahma merged 1 commit intoRicoSuter:masterfrom
lahma merged 1 commit intoRicoSuter:masterfrom
Conversation
…er#1866) When UseSystemTextJson and JsonLibraryVersion >= 9.0, emit EnumMember attribute alongside JsonStringEnumMemberName. This fixes NSwag's ConvertToString which uses reflection to find EnumMemberAttribute for URL parameter serialization. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lahma
force-pushed
the
fix/enum-member-attribute-1866
branch
from
825e6d3 to
2a3b70a
Compare
This was referenced Apr 8, 2026
Merged
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseSystemTextJson && JsonLibraryVersion >= 9.0, the Enum.liquid template only emitted[JsonStringEnumMemberName], dropping[EnumMember]ConvertToStringwhich uses reflection to findEnumMemberAttributefor URL parameter serializationJsonLibraryVersion >= 9.0Test plan
When_enum_has_string_value_then_CS_code_has_JsonStringEnumMemberName_attributeto verify both attributes🤖 Generated with Claude Code